Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update snapshots #2817

Merged
merged 1 commit into from Mar 26, 2024
Merged

chore: update snapshots #2817

merged 1 commit into from Mar 26, 2024

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 26, 2024

Babel repo is updated in #2813 and #2814

Copy link
Member Author

Dunqing commented Mar 26, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 26, 2024
@Dunqing Dunqing requested a review from rzvxa March 26, 2024 03:33
Copy link
Collaborator

@rzvxa rzvxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Sorry for the inconvenience. I really appreciate what you did both with figuring out the babel issue and resolving this.

@Dunqing
Copy link
Member Author

Dunqing commented Mar 26, 2024

There is also another issue, when we update the commit hash of the submodule, we also need to manually execute just submodule to update our cloned repo to be consistent with the configuration in justfile. Otherwise, the snapshot will never be the same. Maybe we check if the commit hash is the same when testing execution

Copy link
Member Author

Dunqing commented Mar 26, 2024

Merge activity

  • Mar 25, 11:52 PM EDT: @Dunqing started a stack merge that includes this pull request via Graphite.
  • Mar 25, 11:53 PM EDT: @Dunqing merged this pull request with Graphite.

@Dunqing Dunqing merged commit 220f722 into main Mar 26, 2024
19 checks passed
@Dunqing Dunqing deleted the 03-26-chore_update_snapshots branch March 26, 2024 03:53
@rzvxa
Copy link
Collaborator

rzvxa commented Mar 26, 2024

There is also another issue, when we update the commit hash of the submodule, we also need to manually execute just submodule to update our cloned repo to be consistent with the configuration in justfile. Otherwise, the snapshot will never be the same. Maybe we check if the commit hash is the same when testing execution

That was exactly my issue, I had them cloned in an older state and I couldn't get the same snapshot as in the CI, I ended up manually fetching and checking out each submodule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants