Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tasks/transforme_conformance): support for testing oxc's test cases #2835

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 27, 2024

Related to: #2822 (comment)

Although babel has a lot of test cases, we still need to add edge cases that babel doesn't have.

This PR will allow us to add our test cases to /root/oxc/tasks/transform_conformance/tests. The directory structure is consistent with babel

For example

# cd /root/oxc/tasks/transform_conformance/tests
- babel-transform-plugin–optional-catch-binding
   - test
       - fixtures
           - your tests # add test cases here

@github-actions github-actions bot added the A-transformer Area - Transformer / Transpiler label Mar 27, 2024
Copy link
Member Author

Dunqing commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@Dunqing Dunqing force-pushed the 03-27-feat_tasks/transforme_conformance_support_for_testing_oxc_s_test_cases branch from 85095d7 to 252f3a8 Compare March 27, 2024 03:37
Copy link

codspeed-hq bot commented Mar 27, 2024

CodSpeed Performance Report

Merging #2835 will improve performances by 5.12%

Comparing 03-27-feat_tasks/transforme_conformance_support_for_testing_oxc_s_test_cases (252f3a8) with main (8c6936a)

Summary

⚡ 1 improvements
✅ 33 untouched benchmarks

Benchmarks breakdown

Benchmark main 03-27-feat_tasks/transforme_conformance_support_for_testing_oxc_s_test_cases Change
parser_napi[checker.ts] 244.5 ms 232.6 ms +5.12%

@Dunqing
Copy link
Member Author

Dunqing commented Mar 27, 2024

@rzvxa cc

@Dunqing Dunqing requested review from Boshen and rzvxa March 27, 2024 03:43
@Boshen Boshen merged commit d671007 into main Mar 27, 2024
33 checks passed
@Boshen Boshen deleted the 03-27-feat_tasks/transforme_conformance_support_for_testing_oxc_s_test_cases branch March 27, 2024 06:14
@rzvxa
Copy link
Collaborator

rzvxa commented Mar 27, 2024

@Dunqing It is awesome, Thanks for putting the time into doing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-transformer Area - Transformer / Transpiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants