Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic): missing SymbolFlags::Export when identifier used in ExportDefaultDeclaration #2837

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Mar 27, 2024

No description provided.

Copy link
Member Author

Dunqing commented Mar 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Dunqing and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added the A-semantic Area - Semantic label Mar 27, 2024
Copy link

codspeed-hq bot commented Mar 27, 2024

CodSpeed Performance Report

Merging #2837 will degrade performances by 3.15%

Comparing 03-27-fix_semantic_missing_SymbolFlags_Export_when_identifier_used_in_ExportDefaultDeclaration (96ba4f1) with main (528744c)

Summary

⚡ 1 improvements
❌ 2 (👁 2) regressions
✅ 31 untouched benchmarks

Benchmarks breakdown

Benchmark main 03-27-fix_semantic_missing_SymbolFlags_Export_when_identifier_used_in_ExportDefaultDeclaration Change
👁 parser_napi[checker.ts] 235.9 ms 243.6 ms -3.15%
👁 parser_napi[pdf.mjs] 73.2 ms 75.5 ms -3.08%
semantic[pdf.mjs] 145.6 ms 139.4 ms +4.44%

@Boshen Boshen merged commit 947a9f0 into main Mar 27, 2024
32 checks passed
@Boshen Boshen deleted the 03-27-fix_semantic_missing_SymbolFlags_Export_when_identifier_used_in_ExportDefaultDeclaration branch March 27, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants