Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(semantic): correctly resolve identifiers inside parameter initializers #3046

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Apr 21, 2024

close: #2644
This fixes function parameters. I think we need an extra AST node to fix catch parameters, which will be the next PR.

@Boshen Boshen requested a review from Dunqing April 21, 2024 11:46
Copy link
Member Author

Boshen commented Apr 21, 2024

@github-actions github-actions bot added the A-semantic Area - Semantic label Apr 21, 2024
Copy link

codspeed-hq bot commented Apr 21, 2024

CodSpeed Performance Report

Merging #3046 will not alter performance

Comparing 04-21-fix_semantic_correctly_resolve_identifiers_inside_parameter_initializers (e941bb8) with main (ee1c0e5)

Summary

✅ 30 untouched benchmarks

Copy link
Member

@Dunqing Dunqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. That's a better solution.

@Boshen Boshen merged commit 1f7033e into main Apr 21, 2024
31 checks passed
@Boshen Boshen deleted the 04-21-fix_semantic_correctly_resolve_identifiers_inside_parameter_initializers branch April 21, 2024 15:38
Copy link
Member Author

Boshen commented Apr 21, 2024

Merge activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-semantic Area - Semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants