Do scroll restoration in userland #1550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-crespo
force-pushed
the
userland-scroll-restore
branch
from
f00ec83
to
f03c734
Compare
|
very silly test
|
david-crespo
force-pushed
the
userland-scroll-restore
branch
from
0ea9c50
to
ae62f5c
Compare
david-crespo
force-pushed
the
userland-scroll-restore
branch
from
dbf0416
to
f9a3248
Compare
|
UGH |
david-crespo
force-pushed
the
userland-scroll-restore
branch
from
4ca3f6d
to
3194abf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1372
Sometimes all it takes is the suggestion that something is possible and you realize it's more than possible — it's easy. Ryan Florence said scroll restoration should be possible in userland with
useNavigation()and from there it took me about 10 minutes and 12 lines to get it working. This means we can scrap our annoying patch that we have to keep updating. This also fixes the Simplebar bug! I think doing scroll restoration at a slightly different, presumably later, point in time means Simplebar has had time to initialize and inflate our scrolling div to its full size.