Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPD proxy needs to implement a subset of TSA2004 temp sensor #545

Open
cbiffle opened this issue May 11, 2022 · 1 comment · May be fixed by #612
Open

SPD proxy needs to implement a subset of TSA2004 temp sensor #545

cbiffle opened this issue May 11, 2022 · 1 comment · May be fixed by #612
Milestone

Comments

@cbiffle
Copy link
Collaborator

cbiffle commented May 11, 2022

During PSP boot, it sends messages to the DIMM temperature sensors to configure temperature alerting thresholds. We're currently nacking them. Somewhat surprisingly, it tolerates this just fine and continues the boot.

We probably shouldn't be nacking them. I suggest that we do the following:

  • Implement a proxy for the alert threshold registers on the temperature sensors.
  • Cache the thresholds it requests
  • Asynchronously apply them to the temperature sensors.

We can't synchronously apply them because of SMBus transaction length limitations (in general, you can't recursively SMBus). But, it's not critical that the alert thresholds be synchronously applied, just promptly applied. We can do that. Probably in another task to keep spd available.

We will also need to implement temperature reads. We're not sure what the PSP does with that information, but, it does appear to read it. This will also need to be asynchronous -- we need to get the temperatures separately and then feed them into the proxy. A delayed reading is probably fine. We could, for instance, push them into the spd task from the thermal task over IPC.

Getting this working will be important for having the PSP set up thermal throttling for memory, which seems like a thing we'll want.

@cbiffle
Copy link
Collaborator Author

cbiffle commented May 11, 2022

Tagging @bcantrill @mkeeter as interested/affected parties

@cbiffle cbiffle added this to the MVP milestone Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant