Fix SPD priority inversion #612
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets the crate provide a default impl, removing some boilerplate from clients, and also will allow I2cControl impls to have _state,_ which is critical for using one to implement an IPC server in the spd proxy.
This will provide a channel for feeding EEPROM data into the cache, incrementally, per the design laid out in #599.
The sequencer task now reads the EEPROMs once it's confident they're available, and pushes the info into the SPD proxy before starting the host. This eliminates the last blocking I2C transfer from the SPD proxy, which should improve its liveness. It also eliminates the priority inversion between SPD (high) and `i2c_driver` (lower). Fixes #599.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes implementing the design outlined in #599, which should in turn fix #545 and #562.