WIP sp_measure: record measurement in attest task
#1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a bit more sense as a default configuration as the rot-carrier is designed to work with the gimletlet.
labbott
reviewed
Aug 8, 2023
That's still the primary driver. Probably worth writing a quick RFD to document whatever decision we make since this is a threat modeling exercise. |
flihp
force-pushed
the
attest-record-spmeasure
branch
2 times, most recently
from
4bad7f0
to
ceba272
Compare
This was great for development. Less so now.
`sp_measure` panic's on most / all errors. This causes `jefe` to restart it. In testing this has casued the `swd` task to get stuck in the RUNNING state. Better to hold this task than lock up the system.
This task is intended to run once when the system boots and the task it performs should not be repeated. Jefe will no longer restart this task and so we could remove the final call to `sys_recv_closed` as well, however tasks that return from their `main` function are reported as having executed an illegal instruction. So we leave this call in place to prevent a scary message from showing up in the task list: `FAULT: illegal instruction (was: ready)`
flihp
force-pushed
the
attest-record-spmeasure
branch
from
ceba272
to
72bfa85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still a work in progress but the basic functionality has been tested successfully on an rot-carrier. This still needs to be integrated w/ the
oxide-rot-1image and tested on a gimlet before merging.