chore: Move interleaved uncontained memory test into cannot_access_uncontained_memory #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty-much zero-benefit PR but it started bugging me that
cannot_access_uncontained_memorywas "spuriously" failing when I'd added the "two good slices interleaved with uncontained memory" case into the fake table.Well, it wasn't spuriously failing. It was just already testing what the
cannot_access_slice_spanning_over_uncontained_memorytest case I added tests, and it was failing because at that point the I still had my attempted improved algorithm in the branch.So in effect: The last added test case can be just replaced with a single addition into the fake table, after which the existing uncontained memory access test takes care of testing that case.