Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade clap to 3.2.5 #161

Closed
wants to merge 2 commits into from
Closed

Upgrade clap to 3.2.5 #161

wants to merge 2 commits into from

Commits on Jun 16, 2022

  1. Upgrade clap to 3.2.5 

    Clap 3.2 is the last release before 4.0:
https://epage.github.io/blog/2022/06/clap-32-last-call-before-40/

These changes upgrade our usage of features that are being deprecated,
insuring that we shall have an easy upgrade path to 4.0.

The two biggest changes:

1. removing NoAutoVersion.
2. changing our usage of parse_int::parse to the new value_parser API

Big thanks to @epage for helping out with 2:
clap-rs/clap#3839

And for working through some error messages:
clap-rs/clap#3822

As for NoAutoVersion, opting into the new behavior via `action` does
what we want, *except* that the output for doing it with another
incorrect flag doesn't give the error about how that's incorrect. I
suspect that this is an acceptable change in behavior, but worth calling
out. You can see the difference in the chip.trycmd tests.
    @steveklabnik
    steveklabnik committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    1a171e1 View commit details
    Browse the repository at this point in the history

  2. Use the new value_source API

    @steveklabnik
    steveklabnik committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8859ce6 View commit details
    Browse the repository at this point in the history