Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rust crate zip to v1 - autoclosed #5592

Closed
wants to merge 1 commit into from

Conversation

oxide-renovate[bot]
Copy link
Contributor

@oxide-renovate oxide-renovate bot commented Apr 21, 2024

This PR contains the following updates:

Package Type Update Change
zip workspace.dependencies major 0.6.6 -> 1.3.1

Release Notes

zip-rs/zip2 (zip)

v1.3.1

Compare Source

🚜 Refactor
  • Make deflate enable both default implementations
  • Merge the hidden deflate-flate2 flag into the public one
  • Rename _deflate-non-zopfli to _deflate-flate2
  • Reject encrypted and using_data_descriptor files slightly faster in read_zipfile_from_stream
  • Convert impl TryInto<NaiveDateTime> for DateTime to impl TryFrom<DateTime> for NaiveDateTime (#​136)
⚑ Performance
  • Change default compression implementation to flate2/zlib-ng
βš™οΈ Miscellaneous Tasks
  • chore(#​132): Attribution for some copied test data
  • chore(#​133): chmod -x src/result.rs

v1.3.0

Compare Source

πŸš€ Features
  • Add is_symlink method
πŸ› Bug Fixes
  • Extract symlinks into symlinks on Unix and Windows, and fix a bug that affected making directories writable on MacOS
🚜 Refactor
  • Eliminate deprecation warning when --all-features implicitly enables the deprecated feature
  • Check if archive contains a symlink's target, without borrowing both at the same time
  • Eliminate a clone that's no longer necessary
  • is_dir only needs to look at the filename
  • Remove unnecessary #[cfg] attributes
βš™οΈ Miscellaneous Tasks
  • Fix borrow-of-moved-value
  • Box doesn't directly convert to PathBuf, so convert back to String first
  • partial revert - only &str has chars(), but Box should auto-deref
  • contains_key needs a Box<str>, so generify is_dir to accept one
  • Add missing ZipFileData::is_dir() method
  • Fix another Windows-specific error
  • More bug fixes for Windows-specific symlink code
  • More bug fixes for Windows-specific symlink code
  • Bug fix: variable name change
  • Bug fix: need both internal and output path to determine whether to symlink_dir
  • Another bug fix
  • Fix another error-type conversion error
  • Fix error-type conversion on Windows
  • Fix conditionally-unused import
  • Fix continued issues, and factor out the Vec-to-OsString conversion (cc: #​125)
  • Fix CI failure involving conversion to OsString for symlinks (see my comments on #​125)
  • Move path join into platform-independent code

v1.2.3

Compare Source

πŸ› Bug Fixes
  • Remove a window when an extracted directory might be unexpectedly listable and/or cdable by non-owners
  • Extract directory contents on Unix even if the directory doesn't have write permission (https://github.com/zip-rs/zip-old/issues/423)
βš™οΈ Miscellaneous Tasks
  • More conditionally-unused imports

v1.2.2

Compare Source

πŸ› Bug Fixes
  • Failed to clear "writing_raw" before finishing a symlink, leading to dropped extra fields
⚑ Performance
  • Use boxed slice for archive comment, since it can't be concatenated
  • Optimize for the fact that false signatures can't overlap with real ones

v1.2.1

Compare Source

πŸ› Bug Fixes
  • Prevent panic when trying to read a file with an unsupported compression method
  • Prevent panic after reading an invalid LZMA file
  • Make Stored the default compression method if Deflated isn't available, so that zip files are readable by as much software as possible
  • version_needed was wrong when e.g. cfg(bzip2) but current file wasn't bzip2 (#​100)
  • file paths shouldn't start with slashes (#​102)
🚜 Refactor
  • Overhaul impl Arbitrary for FileOptions
  • Remove unused atomic module

v1.2.0

Compare Source

πŸš€ Features
  • Add method decompressed_size() so non-recursive ZIP bombs can be detected
🚜 Refactor
  • Make ZipWriter::finish() consume the ZipWriter
βš™οΈ Miscellaneous Tasks
  • Use panic! rather than abort to ensure the fuzz harness can process the failure
  • Update fuzz_write to use replace_with
  • Remove a drop that can no longer be explicit
  • Add #![allow(unexpected_cfgs)] in nightly

v1.1.4

Compare Source

πŸ› Bug Fixes
  • Build was failing with bzip2 enabled
  • use is_dir in more places where Windows paths might be handled incorrectly
⚑ Performance
  • Quick filter for paths that contain "/../" or "/./" or start with "./" or "../"
  • Fast handling for separator-free paths
  • Speed up logic if main separator isn't '/'
  • Drop normalized_components slightly sooner when not using it
  • Speed up path_to_string in cases where the path is already in the proper format
βš™οΈ Miscellaneous Tasks
  • Refactor: can short-circuit handling of paths that start with MAIN_SEPARATOR, no matter what MAIN_SEPARATOR is
  • Bug fix: non-canonical path detection when MAIN_SEPARATOR is not slash or occurs twice in a row
  • Bug fix: must recreate if . or .. is a path element
  • Bug fix
◀️ Revert
  • #​58 (partial): bzip2-rs can't replace bzip2 because it's decompress-only

v1.1.3

Compare Source

πŸ› Bug Fixes
  • Rare bug where find_and_parse would give up prematurely on detecting a false end-of-CDR header

v1.1.2

Compare Source

πŸ› Bug Fixes
  • Alignment was previously handled incorrectly (#​33)
🚜 Refactor
  • deprecate deflate-miniz feature since it's now equivalent to deflate (#​35)

v1.1.1

Compare Source

Added
  • index_for_name, index_for_path, name_for_index: get the index of a file given its path or vice-versa, without
    initializing metadata from the local-file header or needing to mutably borrow the ZipArchive.
  • add_symlink_from_path, shallow_copy_file_from_path, deep_copy_file_from_path, raw_copy_file_to_path: copy a
    file or create a symlink using AsRef<Path> arguments
Changed
  • add_directory_from_path and start_file_from_path are no longer deprecated, and they now normalize .. as well as
    ..

v1.1.0

Added
  • Support for decoding LZMA.
Changed
  • Eliminated a custom AtomicU64 type by replacing it with OnceLock in the only place it's used.
  • FileOptions now has the subtype SimpleFileOptions which implements Copy but has no extra data.

Configuration

πŸ“… Schedule: Branch creation - "after 8pm,before 6am" in timezone America/Los_Angeles, Automerge - "after 8pm,before 6am" in timezone America/Los_Angeles.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@oxide-renovate oxide-renovate bot added the dependencies Pull requests that update a dependency file label Apr 21, 2024
@oxide-renovate
Copy link
Contributor Author

oxide-renovate bot commented Apr 21, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

β™» Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package zip@0.6.6 --precise 1.2.1
warning: `/tmp/renovate/repos/github/oxidecomputer/omicron/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
    Updating crates.io index
error: failed to select a version for the requirement `zip = "^0.6.6"`
candidate versions found which didn't match: 1.2.1
location searched: crates.io index
required by package `omicron-workspace-hack v0.1.0 (/tmp/renovate/repos/github/oxidecomputer/omicron/workspace-hack)`
perhaps a crate was updated and forgotten to be re-vendored?

@oxide-renovate oxide-renovate bot force-pushed the renovate/zip-1.x branch 3 times, most recently from 402757b to b6f6045 Compare April 25, 2024 03:39
@oxide-renovate oxide-renovate bot changed the title chore(deps): update rust crate zip to v1 Update Rust crate zip to v1 Apr 25, 2024
@oxide-renovate oxide-renovate bot force-pushed the renovate/zip-1.x branch 3 times, most recently from dfb4b3a to 0d486e9 Compare May 5, 2024 03:10
@oxide-renovate oxide-renovate bot force-pushed the renovate/zip-1.x branch 2 times, most recently from de15d9a to 6ee9e6f Compare May 9, 2024 03:12
@oxide-renovate
Copy link
Contributor Author

oxide-renovate bot commented May 9, 2024

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

β™» Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path Cargo.toml --package zip@0.6.6 --precise 1.3.1
    Updating crates.io index
error: failed to select a version for the requirement `zip = "^0.6.6"`
candidate versions found which didn't match: 1.3.1
location searched: crates.io index
required by package `gateway-sp-comms v0.1.1 (https://github.com/oxidecomputer/management-gateway-service?rev=2739c18e80697aa6bc235c935176d14b4d757ee9#2739c18e)`
    ... which satisfies git dependency `gateway-sp-comms` (locked to 0.1.1) of package `omicron-gateway v0.1.0 (/tmp/renovate/repos/github/oxidecomputer/omicron/gateway)`
    ... which satisfies path dependency `omicron-gateway` (locked to 0.1.0) of package `gateway-test-utils v0.1.0 (/tmp/renovate/repos/github/oxidecomputer/omicron/gateway-test-utils)`
    ... which satisfies path dependency `gateway-test-utils` (locked to 0.1.0) of package `omicron-omdb v0.1.0 (/tmp/renovate/repos/github/oxidecomputer/omicron/dev-tools/omdb)`
perhaps a crate was updated and forgotten to be re-vendored?

@oxide-renovate oxide-renovate bot force-pushed the renovate/zip-1.x branch 6 times, most recently from 9a5d678 to 3e491cc Compare May 15, 2024 07:26
@oxide-renovate oxide-renovate bot force-pushed the renovate/zip-1.x branch 3 times, most recently from 8c67c40 to 539e21b Compare May 22, 2024 03:54
@oxide-renovate oxide-renovate bot changed the title Update Rust crate zip to v1 Update Rust crate zip to v1 - autoclosed May 24, 2024
@oxide-renovate oxide-renovate bot closed this May 24, 2024
@oxide-renovate oxide-renovate bot deleted the renovate/zip-1.x branch May 24, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

0 participants