Clear XDE underlay when destroying virtual hardware #5602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OPTE now prevents itself from being unloaded if its underlay state is set. Currently, underlay setup is performed only once, and it seems to be the case that XDE can be unloaded in some scenarios (e.g., `a4x2` setup). However, a consequence is that removing the driver requires an extra operation to explicitly clear the underlay state. This PR adds this operation to the `cargo xtask virtual-hardware destroy` command. This is currently blocked on opte#485 being approved/merged. Closes #5314.
FelixMcFelix
added a commit
to oxidecomputer/maghemite
that referenced
this pull request
May 21, 2024
This is needed to support oxidecomputer/omicron#5602.
smklein
approved these changes
May 21, 2024
FelixMcFelix
added a commit
to oxidecomputer/maghemite
that referenced
this pull request
May 23, 2024
* Bump OPTE to API version 0.31 This is needed to support oxidecomputer/omicron#5602. * Update OPTE (again).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPTE now prevents itself from being unloaded if its underlay state is set. Currently, underlay setup is performed only once, and it seems to be the case that XDE can be unloaded in some scenarios (e.g.,
a4x2setup).However, a consequence is that removing the driver requires an extra operation to explicitly clear the underlay state. This PR adds this operation to the
cargo xtask virtual-hardware destroycommand.This is ready for review, but we want to merge after:
Closes #5314.