Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[omdb] improve CLI UX #5627

Conversation

sunshowers
Copy link
Contributor

@sunshowers sunshowers commented Apr 25, 2024

  • Use global = true for global options wherever possible -- this means that
    you can now pass in arguments like --nexus-db-url at the end.
  • Add a few help headings to group together related options.

Depends on #5615 and #5620 (mostly incidentally).

Created using spr 1.3.6-beta.1
@sunshowers
Copy link
Contributor Author

Per discussion with @davepacheco, here's what will be accepted afterwards:

command accept -w? see -w in help? accept --db-url? see --db-url in help?
omdb yes, anywhere yes no no
omdb db yes, anywhere yes yes, after db only yes
omdb db sleds yes, anywhere yes yes, after db or after sleds yes
omdb nexus yes, anywhere yes no no
omdb nexus sleds yes, anywhere yes no no

Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Thank you so much @sunshowers!

Created using spr 1.3.6-beta.1
@sunshowers sunshowers merged commit 539e117 into sunshowers/spr/main.omdb-improve-cli-ux May 14, 2024
12 of 16 checks passed
@sunshowers sunshowers deleted the sunshowers/spr/omdb-improve-cli-ux branch May 14, 2024 03:39
@sunshowers sunshowers restored the sunshowers/spr/omdb-improve-cli-ux branch May 14, 2024 03:39
@sunshowers sunshowers deleted the sunshowers/spr/omdb-improve-cli-ux branch May 14, 2024 03:40
@sunshowers
Copy link
Contributor Author

accidentally landed this onto the wrong branch, re-did in #5755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants