move dpd-client dependency out of omicron common #5738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcgoodfellow
commented
May 11, 2024
| /// Opaque object representing link state. The contents of this object are not | ||
| /// yet stable. | ||
| #[derive(Clone, Debug, Deserialize, Serialize)] | ||
| pub struct SwitchLinkState { |
There was a problem hiding this comment.
The bulk of this PR is moving this type to nexus/types/src/external_api/shared.rs
This breaks downstreams that import omicron_common as the way dpd-client gets built is specific to the omicron build machinery.
rcgoodfellow
force-pushed
the
no-dpd-client-in-common
branch
from
e5bf1d1
to
da728b2
Compare
oximeter imports this and oximeter is imported by downstreams
rcgoodfellow
commented
May 13, 2024
| @@ -27,7 +27,6 @@ http.workspace = true | |||
| ipnetwork.workspace = true | |||
| macaddr.workspace = true | |||
| mg-admin-client.workspace = true | |||
| dpd-client.workspace = true | |||
There was a problem hiding this comment.
This causes downstream breakage, as compilation of this crate requires omicron-specific build machinery.
There was a problem hiding this comment.
ah yeah... I feel like CI should catch this, maybe by building a stub project with omicron-common as its only dependency. Could you file an issue for this?
sunshowers
approved these changes
May 13, 2024
| @@ -27,7 +27,6 @@ http.workspace = true | |||
| ipnetwork.workspace = true | |||
| macaddr.workspace = true | |||
| mg-admin-client.workspace = true | |||
| dpd-client.workspace = true | |||
There was a problem hiding this comment.
ah yeah... I feel like CI should catch this, maybe by building a stub project with omicron-common as its only dependency. Could you file an issue for this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This breaks downstreams that import omicron_common as the way dpd-client gets built is specific to the omicron build machinery.
For example, this happens when trying to bump omicron in maghemite.