New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more HwError
variants
#200
Conversation
I haven't been able to exhaustively test this yet as I need some remote hands for that, but here's an example of where things are headed:
|
be30c2d
to
3529308
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I think these will be very helpful up-stack! What is the plan for releasing it? Just hoping to avoid too many version-mismatch errors!
/// This error has been deprecated in favor of the more explicit and | ||
/// informative errors below (NotPresent, NotPowered, PowerFault, | ||
/// NotInitialized, I2cAddressNack, I2cByteNack). It is being maintained | ||
/// for backwards compatability. | ||
#[cfg_attr(any(test, feature = "std"), error("FPGA reported an I2C error"))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we might want to decorate this with #[deprecated = "Use the more specific error variants instead"]
or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
Well, I think we'd like to get this into dendrite/hubris ASAP since this gives us a much richer view of what is actually happening at the transceiver module. Release 7 is shipping right now, so presumably this will get rolled into Release 8. We should maybe chat with the update folks about how to best go about this. |
Additions in support of oxidecomputer/hubris#1562