Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow active_only_if_file_found to work in specified subdirectory (_DIRECTORY) #3323

Conversation

TimothyEarley
Copy link
Contributor

Fixes #2873

Proposed Changes

Add a new path to check for files specified in active_only_if_file_found, namely the _DIRECTORY setting.
This fixes #2873 by allowing users to use the following config:

KUBERNETES_DIRECTORY: "your-chart-dir"
KUBERNETES_HELM_ARGUMENTS: "your-chart-dir"

Previously this would have still disabled the linter. Now, as long as the KUBERNETES_DIRECTORY has a Chart.yaml, the linter is active.

Readiness Checklist

Author/Contributor

  • Add entry to the CHANGELOG listing the change and linking to the corresponding issue (if appropriate)
  • If documentation is needed for this change, has that been included in this pull request

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

Timothy Earley added 2 commits January 25, 2024 10:43
…y (_DIRECTORY)

Fixes oxsecurity#2873
This includes a new place when searching for active only if files. The other existing places are not affected.
Copy link
Member

@nvuillam nvuillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for the PR :)

@nvuillam nvuillam merged commit ee5c1aa into oxsecurity:main Jan 27, 2024
6 checks passed
@nvuillam
Copy link
Member

@TimothyEarley add me on linkedin if you'd like a mention at the next release :)

@TimothyEarley TimothyEarley deleted the fix/active_only_if_file_found-in-directory branch January 29, 2024 08:37
@TimothyEarley
Copy link
Contributor Author

@TimothyEarley add me on linkedin if you'd like a mention at the next release :)

I don't have LinkedIn, but you can mention my GitHub @TimothyEarley if you want.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems while trying to use kubeconform
2 participants