catch validation error in typeform tasks to sync responses #296
Conversation
| @@ -3,7 +3,7 @@ WORKDIR /opt/app/ | |||
| COPY package.json /opt/app/ | |||
| RUN apk --no-cache add --virtual native-deps \ | |||
| g++ make python && \ | |||
| npm install --quiet --production && \ | |||
| npm install --no-optional --quiet --production && \ | |||
There was a problem hiding this comment.
this is to force fsevents to install even though it's an optional dependency, otherwise it leads to a bunch of ugly warnings.
| @@ -76,11 +77,11 @@ export default class RegistrationModal extends React.Component { | |||
| } | |||
| { | |||
| this.state.registration && | |||
| <p>In order to save your learning circle, you need to register or <a onClick={this.toggleModalType}>log in.</a></p> | |||
| <p>In order to save your learning circle, you need to register or <a href="#" onClick={this.toggleModalType}>log in.</a></p> | |||
There was a problem hiding this comment.
this is just to maintain the link styling
| @@ -1,8 +1,6 @@ | |||
| import React from 'react' | |||
| import InputWithLabel from 'p2pu-input-fields/dist/InputWithLabel' | |||
|
|
|||
| Location | |||
There was a problem hiding this comment.
i think this was a typo?
s-kennedy
force-pushed
the
fix_date_picker_bug
branch
from
cde3a2f
to
840ac74
Compare
s-kennedy
force-pushed
the
fix_date_picker_bug
branch
from
840ac74
to
854d3ab
Compare
| @@ -38,15 +38,15 @@ | |||
| "lodash": "^4.17.11", | |||
| "moment": "^2.18.1", | |||
| "node-sass": "^4.9.3", | |||
| "p2pu-input-fields": "^0.5.9", | |||
| "p2pu-input-fields": "^0.5.10", | |||
There was a problem hiding this comment.
This is where the production bug came from!
In p2pu-input-fields we're using a dependency, react-datepicker. The datepicker made changes in their latest version that are only compatible with React 16, so that was breaking our learning circle creation form.
Here's the issue: Hacker0x01/react-datepicker#1521
In p2pu-input-fields I fixed the version to 1.4.1, which fixed the bug, but it requires react 16 so I also upgraded react. According to the package-lock.json we were already using 15.6.2 so according to the release documentation we should be fine: https://reactjs.org/blog/2017/09/26/react-v16.0.html
I also tested the creation form and the course search and it's all good.
| @@ -104,6 +106,8 @@ def sync_learner_responses(): | |||
| study_group = StudyGroup.objects.get(uuid=study_group_id) | |||
| except ObjectDoesNotExist as e: | |||
| logger.debug('Study group with ID does not exist', e) | |||
| except ValidationError as e: | |||
| logger.debug('UUID is not valid', e) | |||
There was a problem hiding this comment.
On typeform we have a few empty responses where the UUID is saved as xxxxx. I think it happens when someone fills out the form from the editing page on Typeform? Anyway it was throwing this error:
django.core.exceptions.ValidationError: ["'xxxxx' is not a valid UUID."]
So this catches the error, I ran the task locally and it got all the responses.
No description provided.