Draft of changes to introduce new log placeholder "attributes". #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The placeholder for the CustomLineFormat will allow additional attributes to be logged for the Connection, Statement and ResultSet objects. The list of attributes to include in the log will be specified in the suffix of the placeholder like this:
%(attributes:*) - log all captured attributes of the current Category
%(attributes:Statement.*) - log all attributes only for "statement" Category
%(attributes:Connection.getSchema,Statement.isAutoCommitted,ResultSet.*) - log the specified attributes only
This is a draft:
- the list of attributes for each Category is not final and can be extended at any point
- the tests have not been created yet
the-w1nd
commented
Aug 21, 2019
| m.appendTail(output); | ||
| } catch (Exception ex) { | ||
| // Make sure that any exceptions from the Matcher are not breaking the main application | ||
| System.out.println("=== Got Exception : " + Arrays.toString(ex.getStackTrace())); |
There was a problem hiding this comment.
All "System.out.println" calls are going to be removed. Forgot to clean up while learning how to make GitHub forks and pull requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The placeholder for the CustomLineFormat will allow additional attributes to be logged for the Connection, Statement and ResultSet objects. The list of attributes to include in the log will be specified in the suffix of the placeholder like this:
This is a draft: