JUnit 5 migration (#507) #531
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjo67
commented
Apr 18, 2021
| @@ -128,6 +136,9 @@ license { | |||
| } | |||
|
|
|||
| test { | |||
|
|
|||
| useJUnitPlatform() | |||
There was a problem hiding this comment.
I'm not a gradle user, so maybe there's a better way, but without this config I couldn't get the JUnit-5 tests recognised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr migrates to JUnit5 all the tests that do not use the base class P6TestFramework.
the gradle config has been changed to support both junit5- und junit-4 tests.
The test P6TestOptionsRepository is not in this PR, since the use of assertThrows with lambdas requires a base version of java 1.8.