fix(bwrap): dns resolution in the sandbox #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D-Brox
force-pushed
the
fix/cargo
branch
2 times, most recently
from
2089f1b
to
9bec7d3
Compare
Elsie19
requested changes
May 6, 2024
Elsie19
requested changes
May 7, 2024
D-Brox
changed the title
oklopfer
approved these changes
May 7, 2024
oklopfer
requested changes
May 7, 2024
oklopfer
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Since we tmpfs
/runwith bwrap, dns resolution is borked. So we just need to ro-bind the/run/systemd/resolvedir.Approach
Add the flag to bwrap
Progress
Done and tested with cargo packages
Checklist