Skip to content
This repository has been archived by the owner on Dec 1, 2023. It is now read-only.

Fix async and defer options when loading scripts #737

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dawid-in
Copy link

@dawid-in dawid-in commented Aug 19, 2016

Options are stored as value in the array, rather than a key.

[x] I have read and followed the contribution guide: https://github.com/pagekit/pagekit/blob/develop/.github/CONTRIBUTING.md
[x] The destination branch of the pull request is the develop branch

@ahoiroman
Copy link
Contributor

Hi @dawid-in

Could you please tell us a bit more about your pull request? I think it's still possible to use async and defer, using something like:

$app[ 'scripts' ]->add('foo', 'bar', $dependencies, ['defer' => true, 'async' => true]);

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants