fix: [RTD-1145] set Application Insights INFO logging level for RTD microservices #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…RTD microservices
TommasoLencioni
added
no apply
dev
…FO) for RTD microservices" This reverts commit 5cedf6e.
|
🎉 This PR is included in version 1.96.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to remove
APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVELenvironment variable from config maps.List of changes
APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVELenvironment variable.Motivation and context
With this change we can safely update Application Insights agent to >3.4.1 .
In 3.4.2
APPLICATIONINSIGHTS_INSTRUMENTATION_LOGGING_LEVELis no longer ignored, thus every microservice having it toOFFdoes not send logs to Application Insights microsoft/ApplicationInsights-Java#2592.We remove the explicit declaration of the environment variable, so the logging level falls to the default (INFO, that is the desired one indeed).
Type of changes
Does this introduce a change to production resources with possible user impact?
Does this introduce an unwanted change on infrastructure? Check terraform plan execution result
Other information
If PR is partially applied, why? (reserved to mantainers)