-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added depth limit #318
Open
keijokapp
wants to merge
1
commit into
pahen:master
Choose a base branch
from
keijokapp:depth-limit
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added depth limit #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keijokapp
force-pushed
the
depth-limit
branch
2 times, most recently
from
June 24, 2022 17:55
104e0d1
to
77ddee5
Compare
PabloLION
reviewed
Jan 30, 2023
Another thing is about the naming: |
Thanks for the review!
|
keijokapp
force-pushed
the
depth-limit
branch
from
September 30, 2023 11:28
88768b8
to
cd0a06e
Compare
Need testcase. I try to add them later. |
Any update on this? 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
depth
option (and--depth
CLI argument). It can be used to remove all modules from the output that are more thandepth
steps away from the closest input module ("deep dependencies").depth = 0
makes it to only include input modules.Note that the whole tree still gets traversed because deep dependencies could reference back to non-deep modules (i.e. modules that are
<=depth
steps away from any input module). In that case, the intermediate deep dependency is removed and the non-deep dependencies are connected directly. This can cause self-dependent modules.Example:
I haven't written tests yet.