Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Spring Boot 2.4.2 #46

Merged
merged 1 commit into from Jan 21, 2021
Merged

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Jan 21, 2021

In Boot 2.4.2 the format of classpath.idx changed to include the relative path of each jar that should be added to the classpath. Previous in only provided a list of jar names. When generating the classpath, the buildpack will now only prepend the value of Spring-Boot-Lib from the manifest to the indexed entries if the entries are naked file names. It will use the exact path provided if the entry contains a '/'

Also, adds all native-image arguments to the layer metadata (not just additional user provided arguments) so that changes in buildpack computed arguments trigger a rebuild.

Signed-off-by: Emily Casey ecasey@vmware.com

Background:

@ekcasey ekcasey requested a review from a team January 21, 2021 23:26
In Boot 2.4.2 the format of classpath.idx changed to include the relative path of each jar that should be added to the classpath. Previous in only provided a list of jar names. When generating the classpath, the buildpack will now only prepend the value of Spring-Boot-Lib from the manifest to the indexed entries if the entries are naked file names. It will use the exact path provided if the entry contains a '/'

Also, adds all native-image arguments to the layer metadata (not just additional user provided arguments) so that changes in buildpack computed arguments trigger a rebuild.

Signed-off-by: Emily Casey <ecasey@vmware.com>
@ekcasey ekcasey added semver:patch A change requiring a patch version bump type:bug A general bug labels Jan 21, 2021
@ekcasey ekcasey merged commit 42b2c4e into main Jan 21, 2021
@ekcasey ekcasey deleted the bugfix/boot-classpath branch January 21, 2021 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant