Use protoc x86_64 on Apple M1 aarch64 #6005
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals (and why):
==COMMIT_MSG==
Use protoc x86_64 on Apple M1 aarch64
The old protoc version 3.5.1 atlasdb uses does not yet support Apple M1 aarch64
(see protocolbuffers/protobuf#8062), so use x86_64 until
atlasdb upgrades to protoc 3.18.0+ which add osx-aarch_64.
==COMMIT_MSG==
Implementation Description (bullets): Use protoc x86_64 on Apple M1 aarch64, otherwise use protoc for default
osdetector.classifier
protoc 3.18.0+ include fake
osx-aarch64
binaries (e.g. protoc-3.19.2-osx-aarch_64.exe) that are reallyMach-O 64-bit executable x86_64
that OSX will run in Rosetta's Intel compatible mode per protocolbuffers/protobuf#8557Testing (What was existing testing like? What have you done to improve it?): build locally on Apple M1
Concerns (what feedback would you like?): I don't know why AtlasDB's protoc dependency is so ancient (3.5.1), but didn't want to bump it yet until understanding implications
Where should we start reviewing?:
Priority (whenever / two weeks / yesterday):