Fix parsing of docker-compose < 1.25.2 output on narrow terminals #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/docker-compose-rule, @albanf! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
Generate changelog in
|
albanf
force-pushed
the
fix-ps-output-narrow-terminal
branch
from
1e7b661
to
e099725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR
Issue described #411
Fixed for docker-machine in #424, but it's easy to forget to set the
COLUMNSin other contexts.We cannot upgrade to docker-compose 1.25.2+ for various reasons, so this workaround is useful.
After this PR
==COMMIT_MSG==
Works around ps output of docker-compose before 1.25.2 which adjust their output based on the width of the terminal.
==COMMIT_MSG==
Possible downsides?