Skip to content

Commit

Permalink
The mockito error-prone library is no longer included by default
Browse files Browse the repository at this point in the history
It has produced a substantially highter maintenance burden than
we're willing to accept, impacting the error_prone version used
in consumers before we're ready to adopt releases. For example,
google/error-prone#3225 results in
build failures when 2.14.0 is adopted.
  • Loading branch information
carterkozak committed Jun 15, 2022
1 parent 494006a commit 3cb1a32
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 5 deletions.
3 changes: 1 addition & 2 deletions baseline-error-prone/build.gradle
Expand Up @@ -7,7 +7,6 @@ dependencies {
implementation 'com.google.errorprone:error_prone_core'
// Ensure a new enough version of dataflow-errorprone is available
implementation 'org.checkerframework:dataflow-errorprone'
runtimeOnly 'org.mockito:mockito-errorprone'

testImplementation gradleApi()
testImplementation 'com.palantir.tokens:auth-tokens'
Expand Down Expand Up @@ -70,4 +69,4 @@ moduleJvmArgs {
'jdk.compiler/com.sun.tools.javac.util'
]
opens = ['jdk.compiler/com.sun.tools.javac.comp']
}
}
5 changes: 2 additions & 3 deletions versions.lock
Expand Up @@ -17,7 +17,7 @@ com.google.code.findbugs:jsr305:3.0.2 (6 constraints: 66626968)
com.google.errorprone:error_prone_annotation:2.13.1 (3 constraints: c138e9ec)
com.google.errorprone:error_prone_annotations:2.13.1 (12 constraints: 82bdf88c)
com.google.errorprone:error_prone_check_api:2.13.1 (2 constraints: b025d4fe)
com.google.errorprone:error_prone_core:2.13.1 (3 constraints: f4251b64)
com.google.errorprone:error_prone_core:2.13.1 (2 constraints: 0f189366)
com.google.errorprone:error_prone_refaster:2.13.1 (1 constraints: 3905393b)
com.google.errorprone:error_prone_test_helpers:2.13.1 (1 constraints: 3905393b)
com.google.errorprone:error_prone_type_annotations:2.13.1 (1 constraints: 24114cc9)
Expand Down Expand Up @@ -86,8 +86,7 @@ org.hamcrest:hamcrest-core:2.2 (4 constraints: 2b2b359e)
org.hamcrest:hamcrest-library:2.2 (1 constraints: fc138e38)
org.immutables:value:2.8.8 (1 constraints: 14051536)
org.inferred:freebuilder:1.14.6 (1 constraints: 3e053b3b)
org.mockito:mockito-core:4.5.1 (4 constraints: a4328ec8)
org.mockito:mockito-errorprone:4.5.1 (1 constraints: 0c050f36)
org.mockito:mockito-core:4.5.1 (3 constraints: ec24cefa)
org.objenesis:objenesis:3.2 (2 constraints: 9a17f457)
org.ow2.asm:asm:9.3 (3 constraints: e92232eb)
org.pcollections:pcollections:3.1.4 (1 constraints: f51029b8)
Expand Down

0 comments on commit 3cb1a32

Please sign in to comment.