fix(file-name-casing): ignore option works correctly (#4848)

palantir · Sep 9, 2019 · 38ef9d9 · 38ef9d9
1 parent a15541d
commit 38ef9d9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/src/rules/fileNameCasingRule.ts b/src/rules/fileNameCasingRule.ts
@@ -25,7 +25,7 @@ import { isCamelCased, isKebabCased, isPascalCased, isSnakeCased } from "../util
 enum Casing {
     CamelCase = "camel-case",
     PascalCase = "pascal-case",
-    Ignored = "ignored",
+    Ignored = "ignore",
     KebabCase = "kebab-case",
     SnakeCase = "snake-case",
 }
@@ -40,7 +40,13 @@ type ValidationResult = Casing | undefined;
 
 type Validator<T extends Config> = (sourceFile: ts.SourceFile, casing: T) => ValidationResult;
 
-const rules = [Casing.CamelCase, Casing.PascalCase, Casing.KebabCase, Casing.SnakeCase];
+const rules = [
+    Casing.CamelCase,
+    Casing.Ignored,
+    Casing.PascalCase,
+    Casing.KebabCase,
+    Casing.SnakeCase,
+];
 
 const validCasingOptions = new Set(rules);
 

diff --git a/test/rules/file-name-casing/complex/tslint.json b/test/rules/file-name-casing/complex/tslint.json
@@ -1,9 +1,9 @@
 {
   "rules": {
     "file-name-casing": [true, {
-      ".component.ts": "pascal-case",
-      ".tsx": "pascal-case",
-      ".ts": "camel-case"
+      ".component.ts$": "pascal-case",
+      ".tsx$": "pascal-case",
+      ".ts$": "camel-case"
     }]
   }
 }
diff --git a/test/rules/file-name-casing/ignore/tslint.json b/test/rules/file-name-casing/ignore/tslint.json
@@ -1,8 +1,8 @@
 {
     "rules": {
         "file-name-casing": [true, {
-            ".ts": "ignore",
-            ".tsx": "pascal-case"
+            ".ts$": "ignore",
+            ".tsx$": "pascal-case"
         }]
     }
 }