Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

add jsx-ignore option to no-magic-numbers rule #4460

Merged
merged 5 commits into from
Feb 3, 2019
Merged

add jsx-ignore option to no-magic-numbers rule #4460

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9542b5
add jsx-ignore option
Jan 13, 2019
dfdc949
address feedback
Jan 26, 2019
f9401e9
feedback - parse options, add additional test case
Feb 2, 2019
d92452e
feedback - fix conditional
Feb 3, 2019
c9d3dea
feedback - use continue in loop instead
Feb 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/rules/noMagicNumbersRule.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,16 +120,14 @@ function parseOptions(options: Array<OptionsType | number>): ParsedOptionsType {
for (const option of options) {
if (typeof option === "number") {
parsedOptions[ALLOWED_NUMBERS_OPTION].push(option);
}
if (option.hasOwnProperty(ALLOWED_NUMBERS_OPTION)) {
} else if (option.hasOwnProperty(ALLOWED_NUMBERS_OPTION)) {
const numberOptions = (option as AllowedNumbersType)[ALLOWED_NUMBERS_OPTION];
if (Array.isArray(numberOptions) && numberOptions.length > 0) {
numberOptions.forEach((num: number) =>
parsedOptions[ALLOWED_NUMBERS_OPTION].push(num),
);
}
}
if (option.hasOwnProperty(IGNORE_JSX_OPTION)) {
} else if (option.hasOwnProperty(IGNORE_JSX_OPTION)) {
JoshuaKGoldberg marked this conversation as resolved.
Show resolved Hide resolved
parsedOptions[IGNORE_JSX_OPTION] = (option as IgnoreJsxType)[IGNORE_JSX_OPTION];
}
}
Expand Down