Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle RSpec 4 #54

Merged
merged 3 commits into from May 15, 2019
Merged

Handle RSpec 4 #54

merged 3 commits into from May 15, 2019

Conversation

palkan
Copy link
Owner

@palkan palkan commented May 15, 2019

RSpec 4 acquired action-cable-testing.

We need to handle this:

  • If Rails < 6 is used we should provide the missing Rails parts (i.e. test cases) and not include RSpec integration
  • if Rails 6 is used, we shouldn't load any code and print warning "You don't need action-cable-testing anymore"

@palkan palkan force-pushed the chore/rspec4 branch 2 times, most recently from 73c6bcb to 8067313 Compare May 15, 2019 17:11
@palkan palkan force-pushed the chore/rspec4 branch 2 times, most recently from f619579 to 62421eb Compare May 15, 2019 19:45
@palkan palkan merged commit 35de6ff into master May 15, 2019
@palkan palkan deleted the chore/rspec4 branch May 15, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@palkan