Fixed incorrect compilation of async iterator methods (babel#4719)

panagosg7 · Jan 17, 2017 · a17310a · a17310a
1 parent 7eb72bc
commit a17310a
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/packages/babel-helper-remap-async-to-generator/src/index.js b/packages/babel-helper-remap-async-to-generator/src/index.js
@@ -90,6 +90,10 @@ function classOrObjectMethod(path: NodePath, callId: Object) {
       []
     ))
   ];
+
+  // Regardless of whether or not the wrapped function is a an async method
+  // or generator the outer function should not be
+  node.generator = false;
 }
 
 function plainFunction(path: NodePath, callId: Object) {

diff --git a/...ansform-async-generator-functions/test/fixtures/async-generators/class-method/expected.js b/...ansform-async-generator-functions/test/fixtures/async-generators/class-method/expected.js
@@ -1,5 +1,5 @@
 class C {
-  *g() {
+  g() {
     var _this = this;
 
     return babelHelpers.asyncGenerator.wrap(function* () {

diff --git a/...nsform-async-generator-functions/test/fixtures/async-generators/object-method/expected.js b/...nsform-async-generator-functions/test/fixtures/async-generators/object-method/expected.js
@@ -1,5 +1,5 @@
 ({
-  *g() {
+  g() {
     var _this = this;
 
     return babelHelpers.asyncGenerator.wrap(function* () {

diff --git a/...nsform-async-generator-functions/test/fixtures/async-generators/static-method/expected.js b/...nsform-async-generator-functions/test/fixtures/async-generators/static-method/expected.js
@@ -1,5 +1,5 @@
 class C {
-  static *g() {
+  static g() {
     var _this = this;
 
     return babelHelpers.asyncGenerator.wrap(function* () {