Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no_timeout and timeout options for calls #1151

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Add no_timeout and timeout options for calls #1151

wants to merge 1 commit into from

Conversation

lacraig2
Copy link
Member

@lacraig2 lacraig2 commented Dec 23, 2021 •
edited

This PR adds no_timeout to copy_to_guest and record_cmd as well as timeout to record_cmd.

Related to #1150

@lacraig2 lacraig2 linked an issue Dec 23, 2021 that may be closed by this pull request
Question or feature request: PyPanda API for timeout for panda.record_cmd() #1150
Open
@AndrewFasano
Copy link
Member

Adding timeout everywhere looks good, but do we really want to have an int and a bool option for all of these? I'd think we could instead just get rid of the no_timeout flag everywhere. Either way is fine with me though

@lacraig2
Copy link
Member Author

lacraig2 commented Jan 6, 2022

@AndrewFasano That's a good point.

It looks like no_timeout only shows up in one place with run_serial_cmd. Removing it would break things currently using it.

We can certainly make these all take a timeout value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewFasano AndrewFasano Awaiting requested review from AndrewFasano

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question or feature request: PyPanda API for timeout for panda.record_cmd()
2 participants
@lacraig2 @AndrewFasano