Update Poethepoet version #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
reviewed
Jan 3, 2023
pandas-stubs/core/series.pyi
Outdated
| @@ -217,13 +217,43 @@ class Series(IndexOpsMixin, NDFrame, Generic[S1]): | |||
| @overload | |||
| def __new__( | |||
| cls, | |||
| data: IntervalIndex[IntervalT], | |||
| data: IntervalIndex[Interval[int]], | |||
There was a problem hiding this comment.
I assume these changes are from #492
There was a problem hiding this comment.
Ugh. Same mistake again. My local copy of main has the Interval change for some reason, and I keep branching off of that and making the same mistake.
This is now fixed for this PR.
twoertwein
approved these changes
Jan 3, 2023
|
Thanks @Dr-Irv ! |
twoertwein
pushed a commit
to twoertwein/pandas-stubs
that referenced
this pull request
Apr 1, 2023
* split Series[IntervalT] into separate __new__ * update poethepoet version * put back Series.__new__() sing IntervalT * remove import of Interval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #249 we pinned poethepoet because Windows CI was failing as reported in #240
Based on nat-n/poethepoet#88 (comment), poethepoet has been fixed, so put the min version at 0.16.5 which fixed the issue.