Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyright, pandas, mypy versions. Fix nightly tests #920

Merged
merged 4 commits into from May 13, 2024
Merged

Update pyright, pandas, mypy versions. Fix nightly tests #920

merged 4 commits into from May 13, 2024

Conversation

Dr-Irv
Copy link
Collaborator

@Dr-Irv Dr-Irv commented May 12, 2024

Fixed the nightly tests. Revealed some bugs in the dev code.

@Dr-Irv Dr-Irv requested a review from twoertwein May 12, 2024 20:23
twoertwein
twoertwein reviewed May 13, 2024
View reviewed changes
tests/test_groupby.py Outdated
assert_type(GB_DF.resample("ME").interpolate(inplace=True), None),
type(None),
)
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be if PD_LTE_22:?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Not sure why I went that direction. Fixed in 47aac27

twoertwein
twoertwein reviewed May 13, 2024
View reviewed changes
Copy link
Member

@twoertwein twoertwein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I don't understand what's the difference between try and if PD_LTE_22

@twoertwein twoertwein merged commit 6dfa03e into pandas-dev:main May 13, 2024
13 checks passed
@twoertwein
Copy link
Member

Thank you @Dr-Irv !

@twoertwein
Copy link
Member

The CI failed on main:

tests/test_api_types.py:412: error: Expression is of type "Any", not "DataFrame" [assert-type]
tests/test_api_types.py:412: error: Module has no attribute "from_dataframe" [attr-defined]

@Dr-Irv
Copy link
Collaborator Author

Dr-Irv commented May 13, 2024

The CI failed on main:

tests/test_api_types.py:412: error: Expression is of type "Any", not "DataFrame" [assert-type]
tests/test_api_types.py:412: error: Module has no attribute "from_dataframe" [attr-defined]

Weird mypy behavior. Was working locally for me with version 1.10. Updated poetry environment, which only updated as follows:

  - Updating setuptools (68.2.2 -> 69.5.1)
  - Updating lxml (5.2.1 -> 5.2.2)
  - Updating xarray (2024.3.0 -> 2024.5.0)

then it failed locally. Created a fix in #922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twoertwein twoertwein twoertwein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dr-Irv @twoertwein