Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPS/CLN: remove distutils usage #41207

Merged
merged 29 commits into from
May 5, 2021

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Apr 28, 2021

pandas/core/arrays/_arrow_utils.py Outdated Show resolved Hide resolved
pandas/tests/io/test_parquet.py Show resolved Hide resolved
pandas/tests/io/test_parquet.py Show resolved Hide resolved
@lithomas1 lithomas1 added Dependencies Required and optional dependencies Compat pandas objects compatability with Numpy or Python functions Python 3.10 labels Apr 29, 2021
@jreback jreback added this to the 1.3 milestone Apr 30, 2021
@jreback
Copy link
Contributor

jreback commented Apr 30, 2021

hmm didn't realize packaging is a thing.

cc @pandas-dev/pandas-core any comments.

@jorisvandenbossche
Copy link
Member

As mentioned on the issue, we can also vendor the part of the code of packaging that we need (#41199 (comment))

@bashtage
Copy link
Contributor

Why not wait? Python 3.12 is a long way off, and there maybe an official equivalent of LooseVersion in the standard library by then.

@jreback
Copy link
Contributor

jreback commented Apr 30, 2021

Why not wait? Python 3.12 is a long way off, and there maybe an official equivalent of LooseVersion in the standard library by then.

deprecation warnings!

i don't think vendoring would be very hard (and this is in general a nice cleaning anyhow)

@bashtage
Copy link
Contributor

deprecation warnings!

Could just import it once in a compat module and catch the deprecation warning.

@jorisvandenbossche
Copy link
Member

I don't think waiting (and add warning catching as workaround for now) would help much. We will have to otherwise do it in 2 years anyway, and they don't plan to add an alternative to the stdlib.

For reference, this is the PR that vendored it in pyarrow: https://github.com/apache/arrow/pull/9849/files#diff-01d967ca0c7171567d28b14f96289b349089dcab833c61a83d88f3fb72303591

@jreback
Copy link
Contributor

jreback commented Apr 30, 2021

yeah +1 on vendoring.

@bashtage
Copy link
Contributor

If they really aren't going to provide a simple mechanism to handle versioning OOB, then vendoring is the next best. Still total PITA.

@jreback
Copy link
Contributor

jreback commented Apr 30, 2021

If they really aren't going to provide a simple mechanism to handle versioning OOB, then vendoring is the next best. Still total PITA.

for sure! but this is slightly better than existing

@fangchenli fangchenli changed the title DEPS: remove most of distutils usage #41199 DEPS: remove distutils #41199 May 1, 2021
@fangchenli fangchenli changed the title DEPS: remove distutils #41199 DEPS/CLN: remove distutils #41199 May 1, 2021
@jorisvandenbossche jorisvandenbossche changed the title DEPS/CLN: remove distutils #41199 DEPS/CLN: remove distutils usage May 1, 2021
@jreback
Copy link
Contributor

jreback commented May 5, 2021

looks good. can you rebase after #41327 is merged and ping on green.

@simonjayhawkins
Copy link
Member

@fangchenli #41327 now merged

@jreback jreback merged commit f40e58c into pandas-dev:master May 5, 2021
@jreback
Copy link
Contributor

jreback commented May 5, 2021

thanks @fangchenli very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions Dependencies Required and optional dependencies Python 3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPS: remove distutils
7 participants