Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PERF: nancorr pearson #42761

Merged
merged 4 commits into from Jul 31, 2021
Merged

PERF: nancorr pearson #42761

merged 4 commits into from Jul 31, 2021

Conversation

mzeitlin11
Copy link
Member

Benchmarks:

       before           after         ratio
     [e64fcfa7]       [c9a99585]
     <master>         <nancorr_perf>
            52.3M            52.1M     1.00  stat_ops.Correlation.peakmem_corr_wide('pearson')
-         307±5μs         217±10μs     0.71  stat_ops.Correlation.time_corr('pearson')
         132±10μs         138±10μs     1.05  stat_ops.Correlation.time_corr_series('pearson')
-      7.74±0.6ms       2.80±0.2ms     0.36  stat_ops.Correlation.time_corr_wide('pearson')
       9.04±0.7ms       8.22±0.8ms     0.91  stat_ops.Correlation.time_corr_wide_nans('pearson')
       3.92±0.2ms       4.00±0.3ms     1.02  stat_ops.Correlation.time_corrwith_cols('pearson')
       6.99±0.2ms       7.62±0.5ms     1.09  stat_ops.Correlation.time_corrwith_rows('pearson')

@mzeitlin11 mzeitlin11 added Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Performance Memory or execution speed performance labels Jul 28, 2021
@jreback jreback added this to the 1.4 milestone Jul 31, 2021
@jreback jreback merged commit 13560bb into pandas-dev:master Jul 31, 2021
@jreback
Copy link
Contributor

jreback commented Jul 31, 2021

sure, thanks @mzeitlin11

@mzeitlin11 mzeitlin11 deleted the nancorr_perf branch July 31, 2021 01:25
feefladder pushed a commit to feefladder/pandas that referenced this pull request Sep 7, 2021
@mzeitlin11 @feefladder
PERF: nancorr pearson (pandas-dev#42761)
46279be
@phofl phofl mentioned this pull request Jan 26, 2022
Closed
3 tasks
phofl added a commit to phofl/pandas that referenced this pull request Jan 26, 2022
@phofl
Revert "PERF: nancorr pearson (pandas-dev#42761)"
c56e77a 
This reverts commit 13560bb
jreback pushed a commit that referenced this pull request Jan 26, 2022
@phofl
Revert "PERF: nancorr pearson (#42761)" (#45646)
b33c630
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 26, 2022
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Jan 26, 2022
@phofl @meeseeksmachine
Backport PR pandas-dev#45646: Revert "PERF: nancorr pearson (pandas-d…
570c8e8 
…ev#42761)"
jreback pushed a commit that referenced this pull request Jan 27, 2022
@meeseeksmachine @phofl
Backport PR #45646: Revert "PERF: nancorr pearson (#42761)" (#45649)
2fcb0cd 
Co-authored-by: Patrick Hoefler <61934744+phofl@users.noreply.github.com>
@astrojuanlu astrojuanlu mentioned this pull request Mar 10, 2022
Open
yehoshuadimarsky pushed a commit to yehoshuadimarsky/pandas that referenced this pull request Jul 13, 2022
@phofl @yehoshuadimarsky
Revert "PERF: nancorr pearson (pandas-dev#42761)" (pandas-dev#45646)
1ac7824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Algos Non-arithmetic algos: value_counts, factorize, sorting, isin, clip, shift, diff Performance Memory or execution speed performance
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mzeitlin11 @jreback