Modified the doc string of value_counts for DataFrame and series when sort arg is set to false #52857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
reviewed
Apr 23, 2023
mroeschke
added
Docs
Algos
phofl
approved these changes
Apr 25, 2023
|
Thx @VomV |
Rylie-W
pushed a commit
to Rylie-W/pandas
that referenced
this pull request
May 19, 2023
… sort arg is set to false (pandas-dev#52857)
Daquisu
pushed a commit
to Daquisu/pandas
that referenced
this pull request
Jul 8, 2023
… sort arg is set to false (pandas-dev#52857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ✓] closes #51420
Added the explanation of 'sort' keyword for pandas.DataFrame.value_counts and pandas.Series.value_counts. When 'sort' is set to False, value_counts method sorts the dataframe by index. For series, it preserves the order of the data.
The doctest fails due to missing explanation of the return value in value_counts. As it is not related to this issue, it should be handled separately.