Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEPS: Address numpy deprecation of len 1 arrays assignment #52906

Merged
merged 8 commits into from
Apr 26, 2023
Merged

DEPS: Address numpy deprecation of len 1 arrays assignment #52906

merged 8 commits into from
Apr 26, 2023

Conversation

mroeschke
Copy link
Member

@mroeschke mroeschke added the Dependencies Required and optional dependencies label Apr 25, 2023
@MarcoGorelli MarcoGorelli added this to the 2.0.2 milestone Apr 25, 2023
MarcoGorelli
MarcoGorelli approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

there's still some outstanding numpy-dev errors, but happy for this to be merged as-is and they can be addressed later

@mroeschke mroeschke marked this pull request as draft April 25, 2023 18:00
@mroeschke mroeschke marked this pull request as ready for review April 26, 2023 00:49
MarcoGorelli
MarcoGorelli approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

just for my understanding, why arr[0, ...] instead of arr[0]? the former returns a scalar containing the value, the latter the actual value - does it make any difference?

@mroeschke
Copy link
Member Author

There's more detail in numpy/numpy#10615 (comment), but basically arr[0, ...] will return a 0D array vs the actual object which is useful when the object is an array like e.g. (1,) that you want to treat like a scalar

@mroeschke mroeschke merged commit dddc017 into pandas-dev:main Apr 26, 2023
37 checks passed
@mroeschke mroeschke deleted the npdev/deprecation branch April 26, 2023 15:43
@meeseeksmachine meeseeksmachine mentioned this pull request Apr 26, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Apr 26, 2023
@mroeschke @meeseeksmachine
Backport PR pandas-dev#52906: DEPS: Address numpy deprecation of len …
dd6586a 
…1 arrays assignment
phofl pushed a commit that referenced this pull request Apr 26, 2023
@meeseeksmachine @mroeschke
Backport PR #52906 on branch 2.0.x (DEPS: Address numpy deprecation o…
a1c6fe0 
…f len 1 arrays assignment) (#52933)

Backport PR #52906: DEPS: Address numpy deprecation of len 1 arrays assignment

Co-authored-by: Matthew Roeschke <10647082+mroeschke@users.noreply.github.com>
topper-123 pushed a commit to topper-123/pandas that referenced this pull request Apr 27, 2023
@mroeschke @topper-123
DEPS: Address numpy deprecation of len 1 arrays assignment (pandas-de…
b97fe46 
…v#52906)

* DEPS: Address numpy deprecation of len 1 arrays assignment

* Address other failures, and investigate csv failure

* Address csv error, undo one fix

* Undo whitespace

* Turn into 0D array
Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
@mroeschke
DEPS: Address numpy deprecation of len 1 arrays assignment (pandas-de…
e7e7dac 
…v#52906)

* DEPS: Address numpy deprecation of len 1 arrays assignment

* Address other failures, and investigate csv failure

* Address csv error, undo one fix

* Undo whitespace

* Turn into 0D array
@lendle lendle mentioned this pull request Jun 8, 2023
Open
3 tasks
Daquisu pushed a commit to Daquisu/pandas that referenced this pull request Jul 8, 2023
@mroeschke @im-vinicius
DEPS: Address numpy deprecation of len 1 arrays assignment (pandas-de…
b0530e9 
…v#52906)

* DEPS: Address numpy deprecation of len 1 arrays assignment

* Address other failures, and investigate csv failure

* Address csv error, undo one fix

* Undo whitespace

* Turn into 0D array
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Dependencies Required and optional dependencies
Projects
None yet
Milestone
2.0.2
Development

Successfully merging this pull request may close these issues.

CI: NumPy dev build is failing
2 participants
@mroeschke @MarcoGorelli