REGR: DataFrameGroupBy.agg with duplicate column names and a dict #55042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Bug
Groupby
Regression
mroeschke
approved these changes
Sep 7, 2023
|
Thanks @rhshadrach |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 7, 2023
…te column names and a dict
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
got an unexpected keyword argument 'engine_kwargs'when doing groupby in 12.1.0 #55006 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Unlike what I reported in #55006, the core issue is not how we treat kwargs. Rather, I believe the issue occurred in #52115 where logic specific for duplicate columns was added for Series/DataFrame but also impacted groupby.
This PR fixes the regression, but groupby still does not work with duplicate columns. I've confirmed groupby.agg does not work with duplicate columns in this case on 2.0.x, and believe it hasn't for a long time (possibly forever). For this, I've opened #55041.