Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: remove deprecated internals names #58037

Merged
merged 5 commits into from May 8, 2024

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Mar 27, 2024

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Looks like this breaks the min_version build. Is the plan to bump the minimum versions or to change this to a FutureWarning for a cycle?

@mroeschke mroeschke added the Clean label May 8, 2024
@mroeschke mroeschke added this to the 3.0 milestone May 8, 2024
@mroeschke mroeschke merged commit ca55d77 into pandas-dev:main May 8, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the depr-internals branch May 8, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants