BUG: fixes data table alignment when emojis are present #58311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
requested changes
Apr 18, 2024
|
|
||
| emoji_count = sum(len(emoji_pattern.findall(s)) for s in strings) | ||
| if emoji_count > 0: | ||
| set_option("display.unicode.east_asian_width", True) |
There was a problem hiding this comment.
Modifying global setting silently for users is probably not a great user experience as it can lead to silent bugs.
|
Thanks for this PR but I think an appropriate solution needs iterating on the original issue first so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Data tables were misaligned when there were emojis present. This was because the "display.unicode.east_asian_width" setting that already exists was not being set to true when emojis were present. Added code in format.py -> _make_fixed_width() to check whether or not an emoji is present, then set the above display setting to true accordingly.