TST / string dtype: add env variable to enable future_string and add test build #58459
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Testing
jorisvandenbossche
requested review from
phofl and
mroeschke
and removed request for
mroeschke
| @@ -858,7 +858,7 @@ def register_converter_cb(key: str) -> None: | |||
| with cf.config_prefix("future"): | |||
| cf.register_option( | |||
| "infer_string", | |||
| False, | |||
| True if os.environ.get("PANDAS_FUTURE_INFER_STRING", "0") == "1" else False, | |||
There was a problem hiding this comment.
can we make this something that is explicitly FOR_TESTING_ONLY or something to clarify users shouldn't use it
|
started a branch similar to this to get the tests passing; i count 1592 failures locally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #54792
Taking a similar approach as we did for CoW: allow enabling the option with an env variable (also useful for testing locally), and add an extra build on CI with that option enabled.
Not all tests are passing yet, so will see how to mark this build as "allow failures", but I think it would already be useful to set up the infra so we can fix the tests piecewise in follow-ups.