Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Clarify allowed values for on_bad_lines in read_csv #58662

Merged
merged 3 commits into from May 10, 2024

Conversation

wjandrea
Copy link
Contributor

@wjandrea wjandrea commented May 9, 2024

Move the callable options out of the version added/changed tags and improve the flow.

  • [ ] closes #xxxx (Replace xxxx with the GitHub issue number)
  • [ ] Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • [ ] Added type annotations to new arguments/methods/functions.
  • [ ] Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Check my work to make sure I got the details right, please. One thing is, I'm not sure if "process" is the right term for the PyArrow invalid_row_handler since all it does is say "skip" or "error".

BTW, invalid_row_handler isn't mentioned specifically, so at first I thought "signature as described in pyarrow documentation" was referring to the signature of the ParseOptions constructor.

Also, the description should probably state explicitly what happens when the function returns a list of strings with the right number of elements (with engine='python'). I haven't used it myself, but I'm inferring it gets forwarded to the parser that turns a table of strings into a dataframe.

Move the callable options out of the version added/changed tags and improve the flow.
space before colon
@mroeschke mroeschke added the Docs label May 10, 2024
@mroeschke mroeschke added this to the 3.0 milestone May 10, 2024
@mroeschke mroeschke merged commit e67241b into pandas-dev:main May 10, 2024
51 checks passed
@mroeschke
Copy link
Member

Thanks @wjandrea

@wjandrea wjandrea deleted the patch-1 branch May 10, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants