Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WebApp CI with dependency issues #836

Merged
merged 5 commits into from Jun 20, 2023
Merged

Fix WebApp CI with dependency issues #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e73ce5
Use the same version of nodejs as specified in .tool-versions
kachick Jun 20, 2023
dcf99d4
Bump nodejs version as firebase-tools compat
kachick Jun 20, 2023
7e6b1af
`yarn add "@types/node@^16.18.36" --save-dev`
kachick Jun 20, 2023
41179f6
Ignore major updating for types/node
kachick Jun 20, 2023
966825b
Merge branch 'master' into sync-node-version-with-asdf
kachick Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Expand Up @@ -21,6 +21,9 @@ updates:
open-pull-requests-limit: 10
labels:
- automerge
ignore:
- dependency-name: '@types/node'
update-types: ['version-update:semver-major']
- package-ecosystem: gomod
directory: "/hashira-web/functions"
schedule:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/hashira-web--test.yml
View file
Open in desktop
Expand Up @@ -25,9 +25,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: "14"
node-version-file: "hashira-web/.tool-versions"
cache: "yarn"
cache-dependency-path: "hashira-web/yarn.lock"
- run: yarn install
Expand Down
2 changes: 1 addition & 1 deletion hashira-web/.tool-versions
View file
Open in desktop
@@ -1,2 +1,2 @@
yarn 1.22.15
nodejs 16.11.0
nodejs 16.20.0
1 change: 1 addition & 0 deletions hashira-web/package.json
View file
Open in desktop
Expand Up @@ -33,6 +33,7 @@
"vite": "^4.2.0"
},
"dependencies": {
"@types/node": "^16.18.36",
"firebase": "^9.22.1",
"react": "^18.2.0",
"react-dom": "^18.2.0",
Expand Down
5 changes: 5 additions & 0 deletions hashira-web/yarn.lock
View file
Open in desktop
Expand Up @@ -1174,6 +1174,11 @@
resolved "https://registry.yarnpkg.com/@types/node/-/node-18.0.0.tgz#67c7b724e1bcdd7a8821ce0d5ee184d3b4dd525a"
integrity sha512-cHlGmko4gWLVI27cGJntjs/Sj8th9aYwplmZFwmmgYQQvL5NUsgVJG7OddLvNfLqYS31KFN0s3qlaD9qCaxACA==

"@types/node@^16.18.36":
version "16.18.36"
resolved "https://registry.yarnpkg.com/@types/node/-/node-16.18.36.tgz#0db5d7efc4760d36d0d1d22c85d1a53accd5dc27"
integrity sha512-8egDX8dE50XyXWH6C6PRCNkTP106DuUrvdrednFouDSmCi7IOvrqr0frznfZaHifHH/3aq/7a7v9N4wdXMqhBQ==

"@types/prop-types@*":
version "15.7.4"
resolved "https://registry.yarnpkg.com/@types/prop-types/-/prop-types-15.7.4.tgz#fcf7205c25dff795ee79af1e30da2c9790808f11"
Expand Down