Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate lockfile #433

Merged
merged 3 commits into from Dec 2, 2022
Merged

Conversation

CobyPear
Copy link
Member

@CobyPear CobyPear commented Dec 2, 2022

What changes were made?

  • delete node_modules
  • remove auto install peers from npmrc
  • add missing peers manually based on output
  • fix a gatsby issue with the graphql-compose override

I'm inclined to skip changesets here except nextjs-kit as there are no discernible changes to the starters or packages, this is mostly a monorepo change. nextjs-kit has had the vite-plugin-dts replaced with the rollup maintained @rollup/plugin-typescript which allows vite to hook into typescript and read options from the tsconfig. This change was made in a few other packages already.

Where were the changes made?

How have the changes been tested?

Additional information

Why?

Methods to the madness are here: pnpm/pnpm#5144
Seems others have had similar issues after updating pnpm since they changed some things regarding peer deps.

Don't forget to add a changeset if needed!

- delete node_modules
- remove auto install peers from npmrc
- add missing peers manually based on output
- fix a gatsby issue with the graphql-compose override
@CobyPear CobyPear added decoupled-kit Relating to the project or monorepo itself dependencies Dependency management bugfix Fixes a bug or typo labels Dec 2, 2022
@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2022

🦋 Changeset detected

Latest commit: a529abf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@pantheon-systems/nextjs-kit Patch
@pantheon-systems/next-drupal-starter Patch
@pantheon-systems/next-wordpress-starter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vite-plugin-dts was failing to bundle the jsx runtime properly, but the
@rollup/typescript-plugin works better.
@CobyPear CobyPear added the nextjs-kit Relating to the nextjs-kit package label Dec 2, 2022
@backlineint backlineint merged commit 0af36af into pantheon-systems:canary Dec 2, 2022
@CobyPear CobyPear deleted the regen-lockfile branch December 2, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug or typo decoupled-kit Relating to the project or monorepo itself dependencies Dependency management nextjs-kit Relating to the nextjs-kit package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants