Skip to content

Commit

Permalink
replace getDerivedStateFromProps with componentDidUpdate
Browse files Browse the repository at this point in the history
  • Loading branch information
panther711 committed Aug 12, 2019
1 parent 52a3e84 commit e79502b
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 15 deletions.
10 changes: 6 additions & 4 deletions src/widgets/error-panel.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,12 @@ export default class ErrorPanel extends React.PureComponent {
this.hide = this.hide.bind(this);
}

static getDerivedStateFromProps(nextProps, prevState) {
return {
show: !(!nextProps.level)
};
componentDidUpdate(prevProps) {
if (prevProps.level !== this.props.level) {
this.setState({
show: !(!this.props.level)
});
}
}

hide() {
Expand Down
17 changes: 9 additions & 8 deletions umd/index.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -6286,7 +6286,6 @@ var AvatarUpload = function (_React$Component) {
key: "componentDidUpdate",
value: function componentDidUpdate(prevProps) {
if (this.props.avatar != prevProps.avatar) {
console.log("parent changed the avatar", prevProps.avatar, this.props.avatar);
this.setState({
dataUrl: this.props.avatar
});
Expand Down Expand Up @@ -7927,6 +7926,15 @@ var ErrorPanel = function (_React$PureComponent) {
}

_createClass(ErrorPanel, [{
key: "componentDidUpdate",
value: function componentDidUpdate(prevProps) {
if (prevProps.level !== this.props.level) {
this.setState({
show: !!this.props.level
});
}
}
}, {
key: "hide",
value: function hide() {
this.setState({
Expand Down Expand Up @@ -7966,13 +7974,6 @@ var ErrorPanel = function (_React$PureComponent) {
onCancel: this.hide
})));
}
}], [{
key: "getDerivedStateFromProps",
value: function getDerivedStateFromProps(nextProps, prevState) {
return {
show: !!nextProps.level
};
}
}]);

return ErrorPanel;
Expand Down
2 changes: 1 addition & 1 deletion umd/index.dev.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion umd/index.prod.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion umd/index.prod.js.map

Large diffs are not rendered by default.

0 comments on commit e79502b

Please sign in to comment.