update k8s_parser lock; broaden model compatibility #20741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In v1.1.1 hikaru switched from one big package, to a collection of packages: https://github.com/haxsaw/hikaru/blob/main/release_notes.rst#v110 This means that 'which version of hikaru are we using?' and 'which k8s model versions do we support?' become somewhat separte. The sets the minimum version to be where the package revamp happend, and includes the broadest set of model versions currently available.
cburroughs
added
category:internal
|
polite poke for review to see if this is on the right track. |
alonsodomin
approved these changes
Apr 24, 2024
|
When you have a chance, please merge Sorry for letting this one slip through the cracks, I'm assuming it's good to go other than that. |
huonw
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v1.1.1 hikaru switched from one big package, to a collection of packages:
https://github.com/haxsaw/hikaru/blob/main/release_notes.rst#v110
This means that 'which version of hikaru are we using?' and 'which k8s model versions do we support?' become somewhat separte. The sets the minimum version to be where the package revamp happend, and includes the broadest set of model versions currently available.