Mark all Python tools as exportable #20787
Conversation
lilatomic
added
category:new feature
backend: Python
|
When you have a chance, please merge Also, other than that, is this waiting on anything other than hitting the merge button? |
lilatomic
force-pushed
the
feature/export-python-tools
branch
from
70d14d6
to
fad1073
Compare
|
I think we're good to go. I thought that it might be nice to have a toggle to turn this off, in case it causes problems during migration or people don't like the UX of having all resolves suggested together. I'm not sure that's worth the effort, though |
There was a problem hiding this comment.
Thanks!
Looking at that now, it looks like there's a few potential docs that could be updated now that we've got this useful feature:
- https://www.pantsbuild.org/2.22/docs/using-pants/setting-up-an-ide#tool-virtualenvs
- https://www.pantsbuild.org/2.22/docs/python/overview/lockfiles#lockfiles-for-tools "EXPORTING TOOLS REQUIRES A CUSTOM LOCKFILE"
Is that on your radar?
I thought that it might be nice to have a toggle to turn this off, in case it causes problems during migration or people don't like the UX of having all resolves suggested together. I'm not sure that's worth the effort, though
We can see how it goes in dev release testing and retro-fit if required, I imagine?
Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
lilatomic
force-pushed
the
feature/export-python-tools
branch
from
d32b49f
to
83a0d58
Compare
It probably should have been, the purpose of this MR was to remove those 😅. Thanks for pointing them out, I've updated them
Makes sense |
Following to #20730 , this MR flags all Python tools as exportable. It omits some internal tools (for example, parsers for dependency inference).
I think there's a risk that someone tries to export a Python-based tool without activating the Python backend. I also want to look into a few instances where some lockfile rules are registered and see if those registrations are still necessary.