Mark most JVM-based subsystems as exportable #20788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilatomic
added
backend: JVM
|
I categorised this one as an internal change because you could already generate lockfiles for these tools (unlike Python, where you couldn't). |
tdyas
approved these changes
Apr 18, 2024
|
Given this is tagged |
lilatomic
force-pushed
the
feature/export-jvm-tools
branch
from
7414d5e
to
7dab1ff
Compare
|
I called it out, it can't hurt and if we did cause problems then someone debugging can get a hint. |
benjyw
approved these changes
May 20, 2024
We expect no changes, but we might as well call it out.
lilatomic
force-pushed
the
feature/export-jvm-tools
branch
from
7dab1ff
to
d60cc71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all JVM tools which are subsystems to use ExportableTool for lockfile generation.
Some internal tools still use
GenerateJvmToolLockfileSentinelsubclasses. They aren't subsystems, so they'd need some more work. We could either convert them into subsystems (as is done in Python-based backends) although if we don't plan on exposing them (which is the current case) we could also remove the subclass and rule and replace it with a function.