Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for jvm_artifacts target generator #20890

Merged
merged 8 commits into from May 13, 2024

Conversation

grihabor
Copy link
Contributor

@grihabor grihabor commented May 8, 2024

Add docs for the jvm_artifacts target implemented in #20336

@grihabor grihabor changed the title Add docs for jvm_artifacts generator target Add docs for jvm_artifacts target generator May 8, 2024
@huonw huonw added category:documentation release-notes:not-required PR doesn't require mention in release notes labels May 9, 2024
@huonw huonw requested a review from benjyw May 10, 2024 06:22
@huonw
Copy link
Contributor

huonw commented May 10, 2024

I've assumed that this doesn't require release notes, but feel free to add some if it's worth calling out!

@grihabor
Copy link
Contributor Author

@huonw Yeah, I can add a line 5b956fe

@benjyw benjyw added this to the 2.20.x milestone May 13, 2024
@benjyw benjyw merged commit 4012d9e into pantsbuild:main May 13, 2024
25 checks passed
@WorkerPants
Copy link
Member

I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants.

❌ 2.20.x

I was unable to cherry-pick this PR to 2.20.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts:
    git fetch https://github.com/pantsbuild/pants main \
      && git fetch https://github.com/pantsbuild/pants 2.20.x \
      && git checkout -b cherry-pick-20890-to-2.20.x FETCH_HEAD \
      && git cherry-pick 4012d9eff25e6913a32623863f2b646c27fa7e10
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "20890" "2.20.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.

❌ 2.21.x

I was unable to cherry-pick this PR to 2.21.x, likely due to merge-conflicts.

Steps to Cherry-Pick locally

To resolve:

  1. (Ensure your git working directory is clean)
  2. Run the following script to reproduce the merge-conflicts:
    git fetch https://github.com/pantsbuild/pants main \
      && git fetch https://github.com/pantsbuild/pants 2.21.x \
      && git checkout -b cherry-pick-20890-to-2.21.x FETCH_HEAD \
      && git cherry-pick 4012d9eff25e6913a32623863f2b646c27fa7e10
  3. Fix the merge conflicts and commit the changes
  4. Run build-support/cherry_pick/make_pr.sh "20890" "2.21.x"

Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary.


When you're done manually cherry-picking, please remove the needs-cherrypick label on this PR.

Thanks again for your contributions!

🤖 Beep Boop here's my run link

@WorkerPants WorkerPants added the auto-cherry-picking-failed Auto Cherry-Picking Failed label May 13, 2024
@grihabor
Copy link
Contributor Author

@benjyw I have permission problems with build-support/cherry_pick/make_pr.sh, could you please fix the cherry-pick?
You only need to git rm docs/notes/2.22.x.md

Or I could create a completely separate pr

grihabor added a commit to grihabor/pants that referenced this pull request May 13, 2024
Add docs for the `jvm_artifacts` target implemented in
pantsbuild#20336
grihabor added a commit to grihabor/pants that referenced this pull request May 13, 2024
Add docs for the `jvm_artifacts` target implemented in
pantsbuild#20336
@grihabor
Copy link
Contributor Author

grihabor commented May 13, 2024

huonw pushed a commit that referenced this pull request May 13, 2024
…#20919)

Add docs for the `jvm_artifacts` target implemented in
#20336
huonw pushed a commit that referenced this pull request May 13, 2024
…#20920)

Add docs for the `jvm_artifacts` target implemented in
#20336
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-cherry-picking-failed Auto Cherry-Picking Failed category:documentation needs-cherrypick release-notes:not-required PR doesn't require mention in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants